linux-kernel - Re: [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170207224309.9260a3c718911393eda7a4bf@kernel.org>
Date:   Tue, 7 Feb 2017 22:43:09 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     He Kuang <hekuang@...wei.com>
Cc:     <peterz@...radead.org>, <will.deacon@....com>, <mingo@...hat.com>,
        <acme@...nel.org>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...hat.com>, <wangnan0@...wei.com>,
        <bintian.wang@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 1/2] perf tools arm64: Add support for generating bpf
 prologue

On Tue, 7 Feb 2017 07:34:11 +0000
He Kuang <hekuang@...wei.com> wrote:

> Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> regs_query_register_offset() to convert register name to offset for
> arm64, so the BPF prologue feature is ready to use.
> 

Ok, looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

> Signed-off-by: He Kuang <hekuang@...wei.com>
> ---
>  tools/perf/arch/arm64/Makefile          |  1 +
>  tools/perf/arch/arm64/util/dwarf-regs.c | 15 ++++++++++++++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
> index 18b1351..eebe1ec 100644
> --- a/tools/perf/arch/arm64/Makefile
> +++ b/tools/perf/arch/arm64/Makefile
> @@ -2,3 +2,4 @@ ifndef NO_DWARF
>  PERF_HAVE_DWARF_REGS := 1
>  endif
>  PERF_HAVE_JITDUMP := 1
> +PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
> diff --git a/tools/perf/arch/arm64/util/dwarf-regs.c b/tools/perf/arch/arm64/util/dwarf-regs.c
> index d49efeb..068b618 100644
> --- a/tools/perf/arch/arm64/util/dwarf-regs.c
> +++ b/tools/perf/arch/arm64/util/dwarf-regs.c
> @@ -10,17 +10,20 @@
>  
>  #include <stddef.h>
>  #include <dwarf-regs.h>
> +#include <linux/ptrace.h> /* for struct user_pt_regs */
> +#include "util.h"
>  
>  struct pt_regs_dwarfnum {
>  	const char *name;
>  	unsigned int dwarfnum;
>  };
>  
> -#define STR(s) #s
>  #define REG_DWARFNUM_NAME(r, num) {.name = r, .dwarfnum = num}
>  #define GPR_DWARFNUM_NAME(num) \
>  	{.name = STR(%x##num), .dwarfnum = num}
>  #define REG_DWARFNUM_END {.name = NULL, .dwarfnum = 0}
> +#define DWARFNUM2OFFSET(index) \
> +	(index * sizeof((struct user_pt_regs *)0)->regs[0])
>  
>  /*
>   * Reference:
> @@ -78,3 +81,13 @@ const char *get_arch_regstr(unsigned int n)
>  			return roff->name;
>  	return NULL;
>  }
> +
> +int regs_query_register_offset(const char *name)
> +{
> +	const struct pt_regs_dwarfnum *roff;
> +
> +	for (roff = regdwarfnum_table; roff->name != NULL; roff++)
> +		if (!strcmp(roff->name, name))
> +			return DWARFNUM2OFFSET(roff->dwarfnum);
> +	return -EINVAL;
> +}
> -- 
> 1.8.5.2
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>