linux-kernel - Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hwpd2axvl.wl-tiwai@suse.de>
Date:   Tue, 07 Feb 2017 15:17:34 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Jerome Anand" <jerome.anand@...el.com>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused

On Tue, 07 Feb 2017 14:38:51 +0100,
Arnd Bergmann wrote:
> 
> The two functions are unused when CONFIG_PM_SLEEP is disabled:
> 
> sound/x86/intel_hdmi_audio.c:1633:12: error: 'hdmi_lpe_audio_resume' defined but not used [-Werror=unused-function]
> sound/x86/intel_hdmi_audio.c:1622:12: error: 'hdmi_lpe_audio_suspend' defined but not used [-Werror=unused-function]
> 
> Marking them as __maybe_unused avoids the warning without introducing an
> ugly #ifdef.
> 
> Fixes: 182cdf23dbf6 ("ALSA: x86: Implement runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks!


Takashi