linux-kernel - Re: [LTP] [lkp-robot] [fs] 99f64a2676: ltp.creat08.fail & ltp.open10.fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2017 16:12:43 +0100
From:   Cyril Hrubis <chrubis@...e.cz>
To:     kernel test robot <xiaolong.ye@...el.com>
Cc:     Andy Lutomirski <luto@...nel.org>, lkp@...org,
        LKML <linux-kernel@...r.kernel.org>, ltp@...ts.linux.it,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [LTP] [lkp-robot] [fs] 99f64a2676: ltp.creat08.fail &
 ltp.open10.fail

Hi!
> FYI, we noticed the following commit:
> 
> commit: 99f64a2676f0bec4ad32e39fc76eb0914ee091b8 ("fs: Harden against open(..., O_CREAT, 02777) in a setgid directory")
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git vfs/suid
> 
> in testcase: ltp
> with following parameters:
> 
> 	test: ltplite
> 
> test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features.
> test-url: http://linux-test-project.github.io/

Looking at the testcases in question these are testing exactly the
corner case the patch is fixing.

So the tests needs to be fixed once this patch hits mainline. And the
best fix is to expect the SGID flag to be cleared on newer kernels.

-- 
Cyril Hrubis
chrubis@...e.cz