linux-kernel - Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 07 Feb 2017 13:55:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stefan.bruens@...h-aachen.de
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack
 Link Sense Indications

From: David Miller <davem@...emloft.net>
Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST)

> From: Stefan Brüns <stefan.bruens@...h-aachen.de>
> Date: Tue, 7 Feb 2017 03:33:16 +0100
> 
>> If a context is configured as dualstack ("IPv4v6"), the modem indicates
>> the context activation with a slightly different indication message.
>> The dual-stack indication omits the link_type (IPv4/v6) and adds
>> additional address fields.
>> IPv6 LSIs are identical to IPv4 LSIs, but have a different link type.
>> 
>> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
> 
> Applied.
> 
> Ignore my earlier comments about the UMTS comment, it is still
> accurate of course. :-)

Acutally, this still need work.  I had to revert.

You removed the code using the 'eth' variable from sierra_net_bind() but
left the unused variable declared.

Please respin this series with it removed so we don't get the warning:

drivers/net/usb/sierra_net.c: In function ‘sierra_net_bind’:
drivers/net/usb/sierra_net.c:687:17: warning: unused variable ‘eth’ [-Wunused-variable]
  struct ethhdr *eth;