linux-kernel - Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2017 21:33:15 +0100
From:   Van Oostenryck Luc <luc.vanoostenryck@...il.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-sparse@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Christopher Li <sparse@...isli.org>
Subject: Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse

On Tue, Feb 7, 2017 at 9:11 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> On 02/06/2017 05:50 PM, Luc Van Oostenryck wrote:
>> On Mon, Feb 06, 2017 at 05:08:17PM -0800, Stephen Boyd wrote:
>>> On 02/06/2017 05:01 PM, Stephen Boyd wrote:
>>>> When I compile files with sparse, I get these sorts of warnings:
>>>>
>>>> arch/arm64/include/asm/lse.h:14:28: warning: Unknown escape 'l'
>>>> arch/arm64/include/asm/lse.h:14:37: warning: Unknown escape 'l'
>>>> arch/arm64/include/asm/alternative.h:172:28: warning: Unknown escape 'o'
>>>>
>>>> This is because sparse is trying to tokenize these files and sees
>>>> a line like this:
>>>>
>>>>  alternative_insn "\llsc", "\lse", ARM64_HAS_LSE_ATOMICS
>>>>
>>>> It gets past alternative_insn part and then sees the start of a
>>>> string with the double quote character. So sparse starts to parse
>>>> the string (eat_string() in the sparse code) but the string has
>>>> an escape character '\' in it. Sparse sees the escape character,
>>>> so it checks to see if it's an escape sequence, but '\l' isn't.
>>>> This causes sparse to spit out this warning of an unknown escape
>>>> sequence 'l'.
>>>>
>>>> In reality, sparse isn't going to use these macros anyway because
>>>> this whole thing is inside an __ASSEMBLER__ ifdef.
>> Yes, annoying. Conversion of escaped characters is supposed to be
>> done just after preprocessing. It's definitively a bug.
>
> Ok. Thanks for the fixes to sparse. My hack patch can be safely ignored.

Well, I don't know.
Maybe it's still useful for everyone using the official version of sparse
or an older one.

Luc Van Oostenryck