linux-kernel - Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170207205248.GE31091@potion>
Date:   Tue, 7 Feb 2017 21:52:49 +0100
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page
 walk

2017-01-27 19:34+0100, Paolo Bonzini:
> As in the SVM patch, the guest physical address is passed by
> VMX to x86_emulate_instruction already, so mark the GPA as available
> in vcpu->arch.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---

In line with the SVM patch,

Reviewed-by: Radim Krčmář <rkrcmar@...hat.com>

Still, I don't see why we need a variable that is touched on every VM
exit.  Is this a mere shortcut to propagating the gpa_available bit with
the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Thanks.