linux-kernel - Re: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170207211233.ge3fzw5x2fvebpjq@kozik-lap>
Date:   Tue, 7 Feb 2017 23:12:33 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards

On Tue, Feb 07, 2017 at 05:13:25PM +0900, Andi Shyti wrote:
> Add the device tree node for the ir-spi driver which enable the
> ir led for remote controlling.
> 
> This patch sets first the GPR3[3] gpio line as a regulator-fixed
> for enabling an external regulator which powers the IR LED.
> 
> Removes also the default assignment of the GPG3[5] and GPG3[7]
> related to the SPI3 line.
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> ---
>  .../boot/dts/exynos/exynos5433-tm2-common.dtsi     | 27 ++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 098ad557fee3..c61df2318d8b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -106,6 +106,13 @@
>  		};
>  	};
>  
> +	irda_regulator: irda-regulator {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpr3 3 0>;

GPIO_ACTIVE_HIGH

> +		regulator-name = "irda_regulator";
> +	};
> +
>  	sound {
>  		compatible = "samsung,tm2-audio";
>  		audio-codec = <&wm5110>;
> @@ -1073,8 +1080,6 @@
>  
>  		PIN(INPUT, gpg3-0, DOWN, FAST_SR1);
>  		PIN(INPUT, gpg3-1, DOWN, FAST_SR1);
> -		PIN(INPUT, gpg3-5, DOWN, FAST_SR1);
> -		PIN(INPUT, gpg3-7, DOWN, FAST_SR1);

I think gpg3-5 would be missing its configuration. It is not present in
spi3 bus pins. Is it a chip select pin? If you remove the default
configuration, it will still work as input-pull down because no one is
setting different config. Why you need to touch gpg3-5?


Best regards,
Krzysztof