linux-kernel - Re: [PATCH] mm/slub: Fix random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170207134936.2cd986e5b673352d30cfad45@linux-foundation.org>
Date:   Tue, 7 Feb 2017 13:49:36 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Thomas Garnier <thgarnie@...gle.com>
Cc:     Sean Rees <sean@...fax.org>, Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/slub: Fix random_seq offset destruction

On Tue, 7 Feb 2017 07:41:13 -0800 Thomas Garnier <thgarnie@...gle.com> wrote:

> On Tue, Feb 7, 2017 at 6:07 AM, Sean Rees <sean@...fax.org> wrote:
> > Bailout early from init_cache_random_seq if s->random_seq is already
> > initialised. This prevents destroying the previously computed random_seq
> > offsets later in the function.
> >
> > If the offsets are destroyed, then shuffle_freelist will truncate
> > page->freelist to just the first object (orphaning the rest).
> >
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=177551.
> >
> > Signed-off-by: Sean Rees <sean@...fax.org>
> 
> Please add:
> 
> Fixes: 210e7a43fa90 ("mm: SLUB freelist randomization")

I also added

Reported-by: <userwithuid@...il.com>
Cc: <stable@...r.kernel.org>