linux-kernel - Re: [PATCH 1/7] serial: exar: Fix mapping of port I/O resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfGpk_+m=yJAqGNWxVg01UvsFnw5HHOOSCbgXLMLeDUdg@mail.gmail.com>
Date:   Wed, 8 Feb 2017 00:40:21 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Subject: Re: [PATCH 1/7] serial: exar: Fix mapping of port I/O resources

On Tue, Feb 7, 2017 at 6:09 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
> pcim_iomap_table only returns the table of mapping, it does not perform
> them. For that, we need to call pcim_iomap, but only if that mapping was
> not done before.

Basically by this change you answered to one of my question during review.

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> index e6b44a7..58469d9 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -72,6 +72,9 @@ static int default_setup(struct exar8250 *priv, struct pci_dev *pcidev,
>         const struct exar8250_board *board = priv->board;
>         unsigned int bar = 0;
>
> +       if (!pcim_iomap_table(pcidev)[bar] && !pcim_iomap(pcidev, bar, 0))
> +               return -ENOMEM;
> +
>         port->port.iotype = UPIO_MEM;
>         port->port.mapbase = pci_resource_start(pcidev, bar) + offset;
>         port->port.membase = pcim_iomap_table(pcidev)[bar] + offset;
> --
> 2.1.4
>



-- 
With Best Regards,
Andy Shevchenko