linux-kernel - Re: [PATCH 7/7] serial: exar: Enable MSI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcNZt1M0OEGnJz6648JbFfotpsZBFYh46scTL6SW4KduA@mail.gmail.com>
Date:   Wed, 8 Feb 2017 01:26:01 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Subject: Re: [PATCH 7/7] serial: exar: Enable MSI support

On Tue, Feb 7, 2017 at 6:10 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
> Use pci_alloc_irq_vectors to enable MSI when available. At least the
> XR17V352 supports this.
>

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> index 13cc1da..236de60 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -284,10 +284,16 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
>
>         priv->board = board;
>
> +       pci_set_master(pcidev);
> +
> +       rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
> +       if (rc < 0)
> +               return rc;
> +
>         memset(&uart, 0, sizeof(uart));
>         uart.port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF | UPF_SHARE_IRQ
>                           | UPF_EXAR_EFR;
> -       uart.port.irq = pcidev->irq;
> +       uart.port.irq = pci_irq_vector(pcidev, 0);
>         uart.port.dev = &pcidev->dev;
>
>         for (i = 0; i < nr_ports && i < maxnr; i++) {
> --
> 2.1.4
>



-- 
With Best Regards,
Andy Shevchenko