linux-kernel - Re: [PATCH v2 0/4] Improved seccomp logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2017 15:58:53 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Tyler Hicks <tyhicks@...onical.com>
Cc:     Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>, linux-audit@...hat.com,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/4] Improved seccomp logging

On Thu, Feb 2, 2017 at 9:37 PM, Tyler Hicks <tyhicks@...onical.com> wrote:
> This patch set is the second revision of the following two previously
> submitted patch sets:
>
> http://lkml.kernel.org/r/1483375990-14948-1-git-send-email-tyhicks@canonical.com
> http://lkml.kernel.org/r/1483377999-15019-2-git-send-email-tyhicks@canonical.com
>
> The patch set aims to address some known deficiencies in seccomp's current
> logging capabilities:
>
>   1. Inability to log all filter actions.
>   2. Inability to selectively enable filtering; e.g. devs want noisy logging,
>      users want relative quiet.
>   3. Consistent behavior with audit enabled and disabled.
>   4. Inability to easily develop a filter due to the lack of a
>      permissive/complain mode.
>
> The first three items were outlined by Paul Moore and are issues that I agree
> with. The last one is one that I'm particularly interested in.
>
> I deviated a little from the plan that he laid out to address the third issue.
> Looking back at Paul's feedback, he wanted a way to log seccomp actions even
> when the audit subsystem is disabled at build time. I felt like the bigger
> problem is that, while it is common for kernels to be built with audit support,
> it is far less common to actually have auditd running. Therefore, my approach
> was to improve the situation when kernel audit support is enabled at build time
> but audit_enabled is false at runtime. The audit subsystem forwards messages
> onto syslog in that situation.

I'm pretty happy with this series; it's pretty close to something I'd
Ack. :) I think this will get us a lot of what people have asked for
without too much pain. I'll add some thoughts on each of the specific
patches...

-Kees

-- 
Kees Cook
Pixel Security