[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170208060859.GG11154@mwanda>
Date: Wed, 8 Feb 2017 09:09:00 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
On Wed, Feb 08, 2017 at 01:19:39AM +0000, Carlos Palminha wrote:
>
>
> On 08-02-2017 00:58, Dan Carpenter wrote:
> >On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> >>Fixed the following sparse warnings:
> >>* cast from restricted __le32
> >>* invalid assignment from int to __le32
> >>
> >
> >The changelog doesn't give me any confidence that you understand the
> >implications of this patch. You silenced the warning but I think you
> >may be introducing bugs (I haven't done a thourough review).
> >
> >regards,
> >dan carpenter
> >
> true... i was short on words.
> will resend v2 with better description.
I'm pretty sure the original code is correct and just the sparse
annotations are wrong.
regards,
dan carpenter
Powered by blists - more mailing lists