linux-kernel - Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register operations for support sun6i.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208075219.oo234d5zartzmzsg@lukather>
Date:   Wed, 8 Feb 2017 08:52:19 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     lis8215@...il.com
Cc:     linux-sunxi@...glegroups.com, thierry.reding@...il.com,
        robh+dt@...nel.org, mark.rutland@....com, wens@...e.org,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register
 operations for support sun6i.

Hi,

On Tue, Feb 07, 2017 at 08:50:43PM +0300, lis8215@...il.com wrote:
> From: Siarhei Volkau <lis8215@...il.com>
> 
> This patch not introduce new features, just prepare code for
> adding sun6i PWM driver in next commits.
> 
> A31 SoC have a different map of PWM registers than others ASoCs,
> but register bits purposes are very similar.
> 
> This patch introduce set of register access routines, which
> are common for existing in driver ASoCs:
>  - ctl_rdy   - checks the ready bit of specified PWM channel,
>  - ctl_read  - reads value from control register of specified PWM channel,
>  - ctl_write - writes significant bits to control register of specified PWM channel,
>  - prd_read  - reads value from period register of specified PWM channel,
>  - prd_write - writes value to period register of specified PWM channel.
> Driver code redesigned to use the new routines.

Why don't you use regmap for that?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)