linux-kernel - Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208005806.GF11154@mwanda>
Date:   Wed, 8 Feb 2017 03:58:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings

On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> Fixed the following sparse warnings:
> * cast from restricted __le32
> * invalid assignment from int to __le32
> 

The changelog doesn't give me any confidence that you understand the
implications of this patch.  You silenced the warning but I think you
may be introducing bugs (I haven't done a thourough review).

regards,
dan carpenter