linux-kernel - Re: [PATCH] tpm xen: drop unneeded chip variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170208130241.lj7gixi7vhbkfqih@intel.com>
Date:   Wed, 8 Feb 2017 15:02:41 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Peter Huewe <peterhuewe@....de>, kernel-janitors@...r.kernel.org,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm xen: drop unneeded chip variable

On Sun, Feb 05, 2017 at 10:39:37PM +0100, Julia Lawall wrote:
> The call that used chip was dropped in 1f0f30e404b3.  Drop the
> leftover declaration and initialization.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko

> 
> ---
>  drivers/char/tpm/xen-tpmfront.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 5aaa268..656e8af 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  		const struct xenbus_device_id *id)
>  {
>  	struct tpm_private *priv;
> -	struct tpm_chip *chip;
>  	int rv;
>  
>  	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  
>  	rv = setup_ring(dev, priv);
>  	if (rv) {
> -		chip = dev_get_drvdata(&dev->dev);
>  		ring_free(priv);
>  		return rv;
>  	}
>