linux-kernel - Re: [PATCH 1/1] irqchip/mips-gic: Fix local interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8737fo938y.fsf@on-the-bus.cambridge.arm.com>
Date:   Wed, 08 Feb 2017 14:16:45 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Marcin Nowakowski <marcin.nowakowski@...tec.com>
Cc:     <linux-kernel@...r.kernel.org>,
        Paul Burton <paul.burton@...tec.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        <linux-mips@...ux-mips.org>
Subject: Re: [PATCH 1/1] irqchip/mips-gic: Fix local interrupts

On Wed, Jan 25 2017 at  2:08:25 pm GMT, Marcin Nowakowski <marcin.nowakowski@...tec.com> wrote:
> Some local interrupts are not initialised properly at the moment and
> cannot be used since the domain's alloc method is never called for them.
>
> This has been observed earlier and partially fixed in commit
> e875bd66dfb ("irqchip/mips-gic: Fix local interrupts"), but that change
> still relied on the interrupt to be requested by an external driver (eg.
> drivers/clocksource/mips-gic-timer.c).
>
> This does however not solve the issue for interrupts that are not
> referenced by any driver through the device tree and results in
> request_irq() calls returning -ENOSYS. It can be observed when attempting
> to use perf tool to access hardware performance counters.
>
> Fix this by explicitly calling irq_create_fwspec_mapping() for local
> interrupts.
>
> Fixes: e875bd66dfb ("irqchip/mips-gic: Fix local interrupts")
> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@...tec.com>
> Cc: Paul Burton <paul.burton@...tec.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: linux-mips@...ux-mips.org

Queued, thanks.

	M.
-- 
Jazz is not dead, it just smell funny.