linux-kernel - Re: [PATCH] omapfb: dss: Handle return error in dss_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Feb 2017 15:21:43 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tomi.valkeinen@...com, linux-omap@...r.kernel.org,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports.

On Wednesday, February 08, 2017 11:25:47 AM Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote:
> > Hi,
> > 
> > In dss_init_ports, There is no need to add dss_uninit_ports before 
> > returning.
> > Because it's already take care in dss_bind. dss_bind  is handling
> > dss_uninit_ports in error path.
> 
> It doesn't handle cleanup of partially initialized ports,

BTW by "partially initialized ports" here I mean cases like
i.e. dpi port fully initialized and sdi one not initialized

> please look at the code:
> 
> ...
> 	r = dss_init_ports(pdev);
> 	if (r)
> 		goto err_init_ports;
> ...
> err_runtime_get:
> 	pm_runtime_disable(&pdev->dev);
> 	dss_uninit_ports(pdev);
> err_init_ports:
> 	if (dss.video1_pll)
> 		dss_video_pll_uninit(dss.video1_pll);
> ...
> 
> dss_uninit_ports() is not called on partially initialized

ditto

> ports (when dss_init_ports() returns an error we go straight
> into err_init_ports label and skip dss_uninit_ports())
> 
> > -Arvind
> > 
> > 
> > On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote:
> > > dpi_uninit_port() & sdi_uninit_port() skip not fully
> > > initialized port

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics