linux-kernel - Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

Open Source and information security mailing list archives

Date:   Wed, 8 Feb 2017 09:31:00 -0600
From:   Shanker Donthineni <shankerd@...eaurora.org>
To:     Robert Richter <robert.richter@...ium.com>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

Hi Marc,

In teardown path, code is still calling 'kfree(its->cmd_base)' to free 
memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ).

On 02/08/2017 08:43 AM, Robert Richter wrote:
> On 08.02.17 14:41:18, Marc Zyngier wrote:
>> On Wed, Feb 01 2017 at  5:38:25 pm GMT, Robert Richter
> <rrichter@...ium.com> wrote:
>>> The its command buffer must be page aligned, but kzalloc() is not
>>> guaranteed to be (though it is mostly when allocating 64k). Use
>>> __get_free_pages() as this is used for other buffers as well.
>>>
>>> Signed-off-by: Robert Richter <rrichter@...ium.com>
>> I'm still going through this series, but as this is an obvious fix, I've
>> cherry-picked it for 4.11.
> That was actually my intention, thus I placed it first.
>
> -Robert
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives