linux-kernel - Re: [PATCH] serial: st-asc: Use new GPIOD API to obtain RTS pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486571470.2133.404.camel@linux.intel.com>
Date:   Wed, 08 Feb 2017 18:31:10 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>, Lee Jones <lee.jones@...aro.org>
Cc:     kbuild-all@...org, Stephen Rothwell <sfr@...b.auug.org.au>,
        Greg KH <greg@...ah.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Alexander Stein <alexander.stein@...tec-electronic.com>
Subject: Re: [PATCH] serial: st-asc: Use new GPIOD API to obtain RTS pin

On Wed, 2017-02-08 at 21:48 +0800, kbuild test robot wrote:
> Hi Lee,
> 
> [auto build test ERROR on tty/tty-testing]
> [cannot apply to v4.10-rc7 next-20170208]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Lee-Jones/serial-st-a
> sc-Use-new-GPIOD-API-to-obtain-RTS-pin/20170208-180609
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
>  tty-testing
> config: x86_64-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 

It requires to have immutable branch in one of the subsystem which the
other one can pull.

> All errors (new ones prefixed by >>):
> 
>    drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
> > > drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of
> > > function 'devm_fwnode_get_gpiod_from_child' [-Werror=implicit-
> > > function-declaration]
> 
>        gpiod = devm_fwnode_get_gpiod_from_child(port->dev,
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/tty/serial/st-asc.c:578:10: warning: assignment makes
> pointer from integer without a cast [-Wint-conversion]
>        gpiod = devm_fwnode_get_gpiod_from_child(port->dev,
>              ^
>    cc1: some warnings being treated as errors
> 
> vim +/devm_fwnode_get_gpiod_from_child +578 drivers/tty/serial/st-
> asc.c
> 
>    572		} else {
>    573			/* If flow-control disabled, it's safe
> to handle RTS manually */
>    574			if (!ascport->rts && ascport-
> >states[NO_HW_FLOWCTRL]) {
>    575				pinctrl_select_state(ascport-
> >pinctrl,
>    576						     ascport-
> >states[NO_HW_FLOWCTRL]);
>    577	
>  > 578				gpiod =
> devm_fwnode_get_gpiod_from_child(port->dev,
>    579									
>  "rts",
>    580									
>  &np->fwnode,
>    581									
>  GPIOD_OUT_LOW,
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy