linux-kernel - Re: [PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Feb 2017 13:15:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Alexey.Brodkin@...opsys.com
Cc:     netdev@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-kernel@...r.kernel.org, m-karicheri2@...com, nsekhar@...com,
        grygorii.strashko@...com, f.fainelli@...il.com,
        mugunthanvnm@...com, andrew@...n.ch
Subject: Re: [PATCH] net: phy: dp83867: Fall-back to default values of
 clock delay and FIFO depth

From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Date: Mon,  6 Feb 2017 22:24:45 +0300

> Given there're default values mentioned in the PHY datasheet
> fall-back gracefully to them instead of silently return an error
> through the whole call-chain.
> 
> This allows to use minimalistic description in DT if no special
> features are required.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>

If these defaults are legitimate to use, then you should probably also
set them in the non-CONFIG_OF_MDIO case implementation of
dp83867_of_init().

But I'd like to see feedback and reviews from other PHY area experts
before I even consider that updated version of this change.

Thanks.