linux-kernel - Re: mm: testcases for RODATA: renamed Kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJA6EwdRsqywRXgGy7E3N1GviOBRNuiq4_GvCdiN9_eLQ@mail.gmail.com>
Date:   Wed, 8 Feb 2017 11:34:16 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Valentin Rothberg <valentinrothberg@...il.com>
Cc:     Jinbum Park <jinb.park7@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: mm: testcases for RODATA: renamed Kconfig option

On Wed, Feb 8, 2017 at 1:34 AM, Valentin Rothberg
<valentinrothberg@...il.com> wrote:
> Hi Jinbum,
>
> your commit bf9058f08772 ("mm: add arch-independent testcases for
> RODATA") has shown up in today's linux next and ran into an issue with
> another commit.
>
> The added testcases depend on DEBUG_RODATA_TEST, which further depends
> on DEBUG_RODATA.  DEBUG_RODATA, however, has been renamed to
> STRICT_KERNEL_RWX by commit 0f5bf6d0afe4 ("arch: Rename
> CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX").
>
> Long story short.  DEBUG_RODATA_TEST is currently dead, since
> DEBUG_RODATA doesn't exist anymore.  If you want to, I can send a
> trivial patch that renames the dependency and renames
> DEBUG_RODATA_TEST to STRICT_KERNEL_RWX_TEST to keep consistency.
>
> I detected the issue with scripts/checkkconfigsymbols.py.

Since DEBUG_RODATA_TEST only tests RO-ness, let's leave it named
as-is, but fix the config dependency.

-Kees

-- 
Kees Cook
Pixel Security