linux-kernel - Re: [PATCH 14/53] sched/headers: Move 'struct user_struct' definition and APIs to the new <linux/sched/user.h> header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208212247.GA12173@gmail.com>
Date:   Wed, 8 Feb 2017 22:22:47 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Galbraith <efault@....de>,
        Oleg Nesterov <oleg@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 14/53] sched/headers: Move 'struct user_struct'
 definition and APIs to the new <linux/sched/user.h> header


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Wed, Feb 8, 2017 at 10:44 AM, Ingo Molnar <mingo@...nel.org> wrote:
> > 'struct user_struct' was added to sched.h historically, but it's actually
> > entirely independent of task_struct and of scheduler details, so move
> > it to its own header.
> 
> Hmm. I wonder if this would make more sense not even under the
> "<linux/sched/xyz>" hierarchy. It has nothing to do with the
> scheduling at all, really.
> 
> Small nit and can be left for later.

Yeah. Some of the others could be moved to include/linux/ as well, such as:

   <linux/sched/jobctl.h> => <linux/jobctl.h>
   <linux/sched/xacct.h>  => <linux/xacct.h>
   <linux/sched/user.h>   => <linux/user.h>

All of these are pretty unrelated to scheduling, they just happen to be about 
fields that are in task_struct.

<linux/user.h> already exists, it wraps asm/user.h - I suspect the 
<linux/sched/user.h> bits can just be appended to it, plus a header guard.

Thanks,

	Ingo