linux-kernel - Re: [PATCH v2] tools lib traceevent: Robustify do_generate_dynamic_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Feb 2017 21:03:36 -0800
From:   David Carrillo-Cisneros <davidcc@...gle.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Wang Nan <wangnan0@...wei.com>, He Kuang <hekuang@...wei.com>,
        Michal Marek <mmarek@...e.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v2] tools lib traceevent: Robustify do_generate_dynamic_list_file

> bash has some shell opts to control some aspects of compatibility with string
> comparisions that could have some default different from ubuntu and fedora,
> I couldn't find one that looked related, sigh.

The joys of batch scripting...

>
> Anyway, the difference in the order of the symbol types is related to locales, which
> are fixed in the Makefiles to avoid those problems, so in both Fedora and Ubuntu
> that symbol_type evaluates to "U W w" and the file is generated as intended.
>
> So I'm just replacing == with = and running a new set of container based distro tests.
>

"=" works fine in my build. Thanks for looking into this. Next time I
will pay attention to bash portability.

Thanks,
David