linux-kernel - Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170209080917.GA23016@bbox>
Date:   Thu, 9 Feb 2017 17:09:17 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
CC:     Yisheng Xie <xieyisheng1@...wei.com>, <akpm@...ux-foundation.org>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <sergey.senozhatsky@...il.com>, <ngupta@...are.org>,
        <guohanjun@...wei.com>
Subject: Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc

On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > Cc: Minchan Kim <minchan@...nel.org>
> > Cc: Nitin Gupta <ngupta@...are.org>
> > Cc: Hanjun Guo <guohanjun@...wei.com>
Acked-by: Minchan Kim <minchan@...nel.org>

> > ---
> > v2:
> >  * just delete the comment for it is no need anymore, suggested by Sergey.
> 
> thanks for the patch.
> 
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.

I agree on Sergey's opinion.

Andrew,
Please drop previous patch and replace it with this.

Thanks.