lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Feb 2017 09:44:17 +0100 From: Richard Leitner <richard.leitner@...data.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Richard Leitner <dev@...l1n.net>, Greg KH <gregkh@...uxfoundation.org> CC: <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, <robh+dt@...nel.org>, <mark.rutland@....com>, <stern@...land.harvard.edu> Subject: Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ? > > Does it make any sense? > > Even just name of your function is longer than what it substitutes. Well, you're right :-) So I'll change that for v5. Thanks!
Powered by blists - more mailing lists