linux-kernel - Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c10cdf0-5b91-000c-a8c3-78f41d47bac3@gmail.com>
Date:   Thu, 9 Feb 2017 09:50:23 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in
 aspeed_smc_probe()

On 02/08/2017 05:23 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
>  drivers/mtd/spi-nor/aspeed-smc.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 7c86099..56051d3 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	controller->regs = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(controller->regs)) {
> -		dev_err(dev, "Cannot remap controller address.\n");
> +	if (IS_ERR(controller->regs))
>  		return PTR_ERR(controller->regs);
> -	}
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	controller->ahb_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(controller->ahb_base)) {
> -		dev_err(dev, "Cannot remap controller address.\n");
> +	if (IS_ERR(controller->ahb_base))
>  		return PTR_ERR(controller->ahb_base);
> -	}
>  
>  	ret = aspeed_smc_setup_flash(controller, np, res);
>  	if (ret)
> 
> 
> 


-- 
Best regards,
Marek Vasut