linux-kernel - Re: [PATCH 1/4] reset: ath79: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170209100334.462049d5@avionic-0020>
Date:   Thu, 9 Feb 2017 10:03:34 +0100
From:   Alban <albeu@...e.fr>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Alban <albeu@...e.fr>, <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH 1/4] reset: ath79: make it explicitly non-modular

On Tue, 7 Feb 2017 19:18:44 -0500
Paul Gortmaker <paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/reset/Kconfig:config RESET_ATH79
> drivers/reset/Kconfig:  bool "AR71xx Reset Driver" if COMPILE_TEST
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Alban Bedel <albeu@...e.fr>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Alban Bedel <albeu@...e.fr>

Content of type "application/pgp-signature" skipped