linux-kernel - Re: [PATCH] bus: arm-ccn: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f78efc3e-15d0-f5a5-741c-1a17ded786df@osg.samsung.com>
Date:   Thu, 9 Feb 2017 11:53:13 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Pawel Moll <pawel.moll@....com>, linux-kernel@...r.kernel.org
Cc:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] bus: arm-ccn: Fix module autoload

Hello Pawel,

On 02/06/2017 10:05 AM, Pawel Moll wrote:
> On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
>> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
>>>
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE()
>>> macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> $
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> alias:          of:N*T*Carm,ccn-504C*
>>> alias:          of:N*T*Carm,ccn-504
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>> ---
>> Any comments about this patch?
> 
> Sorry, I clearly missed that in my mailbox at the beginning of the
> year.
> 
> It all makes sense to me. I'll try to test it out soon and will make
> sure to include it next time I send out CCN update.
>

Ok, thanks a lot!
 
> Thanks!
> 
> Paweł
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America