linux-kernel - Re: [PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJXy=O2OeLp3dVqurgoJYWvoypYL2WuMqazOBumBd_conA@mail.gmail.com>
Date:   Thu, 9 Feb 2017 17:45:32 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Sekhar Nori <nsekhar@...com>, Rob Herring <robh@...nel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call
 in da8xx_ddrctl_probe()

2017-02-09 16:28 GMT+01:00 Wei Yongjun <weiyj.lk@...il.com>:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/memory/da8xx-ddrctl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/da8xx-ddrctl.c b/drivers/memory/da8xx-ddrctl.c
> index 030afbe..3286aee 100644
> --- a/drivers/memory/da8xx-ddrctl.c
> +++ b/drivers/memory/da8xx-ddrctl.c
> @@ -122,10 +122,8 @@ static int da8xx_ddrctl_probe(struct platform_device *pdev)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         ddrctl = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(ddrctl)) {
> -               dev_err(dev, "unable to map memory controller registers\n");
> +       if (IS_ERR(ddrctl))
>                 return PTR_ERR(ddrctl);
> -       }
>
>         for (; setting->name; setting++) {
>                 knob = da8xx_ddrctl_match_knob(setting);
>
>
>

Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>