[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMpxmJXKwOQfqkGJH0J8QRZNw3wvxchor=UTqnvnxZhCn+x0sQ@mail.gmail.com>
Date: Thu, 9 Feb 2017 17:45:45 +0100
From: Bartosz Golaszewski <bgolaszewski@...libre.com>
To: Wei Yongjun <weiyj.lk@...il.com>
Cc: Sekhar Nori <nsekhar@...com>, Rob Herring <robh@...nel.org>,
Kevin Hilman <khilman@...libre.com>,
Wei Yongjun <weiyongjun1@...wei.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe()
2017-02-09 16:30 GMT+01:00 Wei Yongjun <weiyj.lk@...il.com>:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> drivers/bus/da8xx-mstpri.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index 9af9bcc..5595af1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -218,10 +218,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> mstpri = devm_ioremap_resource(dev, res);
> - if (IS_ERR(mstpri)) {
> - dev_err(dev, "unable to map MSTPRI registers\n");
> + if (IS_ERR(mstpri))
> return PTR_ERR(mstpri);
> - }
>
> prio_list = da8xx_mstpri_get_board_prio();
> if (!prio_list) {
>
>
>
Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
Powered by blists - more mailing lists