linux-kernel - Re: [PATCH] staging: greybus: uart: fix uninitialized newline.flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170209164534.GA17599@localhost>
Date:   Thu, 9 Feb 2017 17:45:34 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     David Lin <dtwlin@...il.com>, Johan Hovold <johan@...nel.org>,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: uart: fix uninitialized
 newline.flow_control

On Thu, Feb 09, 2017 at 01:01:18PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently newline.flow_control is uninitialized, so it can contain
> any garbage from the stack.  I believe it should be initialized with
> GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS
> enabled.

Good catch. The CRTSCTS flag is actually honoured a bit further down in
the set_termios(), but there's a bug in that it assumes newline to have
been initialised with the current (old) values. It should
unconditionally set the flow_control field rather than manipulate bits
(we currently use one bit of this field).

Care to send a v2 fixing this up as suggested above?

Thanks,
Johan