linux-kernel - Re: [PATCH v2] vfio/mdev: Use a module softdep for vfio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73aaa70c-e56a-2713-410b-9a492571fa76@nvidia.com>
Date:   Fri, 10 Feb 2017 00:35:46 +0530
From:   Kirti Wankhede <kwankhede@...dia.com>
To:     Alex Williamson <alex.williamson@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>
Subject: Re: [PATCH v2] vfio/mdev: Use a module softdep for vfio_mdev

On 2/9/2017 3:46 AM, Alex Williamson wrote:
> Use an explicit module softdep rather than a request module call such
> that the dependency is exposed to userspace.  This allows us to more
> easily support modules loaded at initrd time.
> 
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
>

Looks good to me.
Reviewed by: Kirti Wankhede <kwankhede@...dia.com>

Thanks,
Kirti

> v2: Remove request_module call as well, update description.
> 
>  drivers/vfio/mdev/mdev_core.c |   14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
> index 36d75c367d22..126991046eb7 100644
> --- a/drivers/vfio/mdev/mdev_core.c
> +++ b/drivers/vfio/mdev/mdev_core.c
> @@ -422,18 +422,7 @@ int mdev_device_remove(struct device *dev, bool force_remove)
>  
>  static int __init mdev_init(void)
>  {
> -	int ret;
> -
> -	ret = mdev_bus_register();
> -
> -	/*
> -	 * Attempt to load known vfio_mdev.  This gives us a working environment
> -	 * without the user needing to explicitly load vfio_mdev driver.
> -	 */
> -	if (!ret)
> -		request_module_nowait("vfio_mdev");
> -
> -	return ret;
> +	return mdev_bus_register();
>  }
>  
>  static void __exit mdev_exit(void)
> @@ -451,3 +440,4 @@ static void __exit mdev_exit(void)
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR(DRIVER_AUTHOR);
>  MODULE_DESCRIPTION(DRIVER_DESC);
> +MODULE_SOFTDEP("post: vfio_mdev");
>