linux-kernel - Re: [PATCH] drivers: usb: usbip: Add missing break statement to switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2017 12:44:32 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        valentina.manea.m@...il.com, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        peter.senna@...il.com, Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] drivers: usb: usbip: Add missing break statement to
 switch

On 02/09/2017 12:49 AM, Gustavo A. R. Silva wrote:
> Add missing break statement to prevent the code for case
> USB_PORT_FEAT_C_RESET falling through to the default case.
> 
> Addresses-Coverity-ID: 143155
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/usb/usbip/vhci_hcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c4724fb..e4cb9f0 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -313,6 +313,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>  			default:
>  				break;
>  			}
> +			break;
>  		default:
>  			usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n",
>  					  wValue);
> 


Looks good to me.

Acked-by: Shuah Khan <shuahkh@....samsung.com>

thanks,
-- Shuah