linux-kernel - Re: [PATCH] jump_label: mark __start/stop___jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170209234001-mutt-send-email-mst@kernel.org>
Date:   Thu, 9 Feb 2017 23:40:43 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jason Baron <jbaron@...mai.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Borislav Petkov <bp@...en8.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mel Gorman <mgorman@...e.de>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] jump_label: mark __start/stop___jump_table const

On Thu, Feb 09, 2017 at 11:11:32PM +0200, Michael S. Tsirkin wrote:
> Attempts to assign values through these pointers would fail.
> Mark them const to make sure the failure is compile time.
> 
> Cc: Jason Baron <jbaron@...mai.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Hmm this produces a bunch of warnings that I managed
to somehow miss. Self-Nack. Pls disregard.

> ---
>  include/linux/jump_label.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index a0547c5..48ed83f 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -132,8 +132,8 @@ static __always_inline bool static_key_true(struct static_key *key)
>  	return !arch_static_branch(key, true);
>  }
>  
> -extern struct jump_entry __start___jump_table[];
> -extern struct jump_entry __stop___jump_table[];
> +extern const struct jump_entry __start___jump_table[];
> +extern const struct jump_entry __stop___jump_table[];
>  
>  extern void jump_label_init(void);
>  extern void jump_label_lock(void);
> -- 
> MST