[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <04ca01d28324$d1a99960$74fccc20$@opengridcomputing.com>
Date: Thu, 9 Feb 2017 16:35:30 -0600
From: "Steve Wise" <swise@...ngridcomputing.com>
To: "'Joe Perches'" <joe@...ches.com>,
"'Steve Wise'" <swise@...lsio.com>
Cc: "'Doug Ledford'" <dledford@...hat.com>,
"'Sean Hefty'" <sean.hefty@...el.com>,
"'Hal Rosenstock'" <hal.rosenstock@...il.com>,
<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
> Subject: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
>
> Using the normal mechanism, not an indirected one, is clearer.
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 ++---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 174 ++++++++++++------------
> drivers/infiniband/hw/cxgb3/cxio_hal.h | 2 -
> drivers/infiniband/hw/cxgb3/cxio_resource.c | 20 +--
> drivers/infiniband/hw/cxgb3/iwch.c | 6 +-
> drivers/infiniband/hw/cxgb3/iwch_cm.c | 203
++++++++++++++--------------
> drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +--
> drivers/infiniband/hw/cxgb3/iwch_cq.c | 14 +-
> drivers/infiniband/hw/cxgb3/iwch_ev.c | 15 +-
> drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +-
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++++++-------
> drivers/infiniband/hw/cxgb3/iwch_provider.h | 9 +-
> drivers/infiniband/hw/cxgb3/iwch_qp.c | 60 ++++----
> 13 files changed, 329 insertions(+), 330 deletions(-)
>
Looks good (and thanks).
Reviewed-by: Steve Wise <swise@...ngridcomputing.com>
Powered by blists - more mailing lists