linux-kernel - Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2017 14:59:27 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Andi Kleen <andi@...stfloor.org>, peterz@...radead.org,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Support end symbols with no size for
 filters

> > -		no_size = !!size;
> 
> Erk!  Isn't the logic is the wrong way around here.  Sorry!
> i.e. should be:

Yes it works with that change too.

> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index c5a6e0b12452..78bd632f144d 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		filt->addr = start;
>  		if (filt->range && !filt->size && !filt->sym_to) {
>  			filt->size = size;
> -			no_size = !!size;
> +			no_size = !size;
>  		}
>  	}
>  
> @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		if (err)
>  			return err;
>  		filt->size = start + size - filt->addr;
> -		no_size = !!size;
> +		no_size = !size;
>  	}
>