linux-kernel - Re: [PATCH v2 2/3] auxdisplay: ht16k33: rework input device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170210093208.4a0d7e51@erd979>
Date:   Fri, 10 Feb 2017 09:32:08 +0100
From:   Robin van der Gracht <robin@...tonic.nl>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 2/3] auxdisplay: ht16k33: rework input device
 initialization

On Thu,  9 Feb 2017 10:15:52 -0800
Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:

> This patch fixes following issues in input device (keypad) handling:
> 
> - requesting IRQ before allocating and initializing parts of the device
>   that can be referenced from IRQ handler is racy, even if we try to
>   disable interrupt after requesting it. Let's move allocations around
>   so that everything is ready by the time we request IRQ.
> 
> - using threaded interrupt handler to schedule a work item it sub-optimal.
>   Disabling and then re-enabling interrupts in work item and in open/close
>   methods is prone to races and exactly the reason theraded interrupts were
>   introduced. Let's use the infrastructure properly and keep scanning the
>   matrix array in IRQ thread, stopping when there are no keys, or when told
>   to do so.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> 
> v2: addressed Robin's feedback - changed interrupt trigger from
>     IRQF_TRIGGER_RISING to IRQF_TRIGGER_HIGH
> 

Works like a charm!

Tested-by: Robin van der Gracht <robin@...tonic.nl>