linux-kernel - Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170210082027.GA20691@gmail.com>
Date:   Fri, 10 Feb 2017 09:20:27 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Wei Yongjun <weiyongjun1@...wei.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from
 intel_rdt_rdtgroup.c


* Wei Yongjun <weiyj.lk@...il.com> wrote:

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> index 8af04af..759577d 100644
> --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> @@ -27,7 +27,6 @@
>  #include <linux/seq_file.h>
>  #include <linux/sched.h>
>  #include <linux/slab.h>
> -#include <linux/cpu.h>
>  #include <linux/task_work.h>
>  
>  #include <uapi/linux/magic.h>

Same comment as for your other trivial patch: the list of includes in that .c file 
can probably be further reduced.

I.e. instead of a mindless single liner that helps no-one, try to improve the code 
for real.

Thanks,

	Ingo