linux-kernel - Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17885154-71f7-2d1e-7046-757e092de508@phrozen.org>
Date:   Fri, 10 Feb 2017 10:12:24 +0100
From:   John Crispin <john@...ozen.org>
To:     André Draszik <git@...red.net>,
        linux-kernel@...r.kernel.org
Cc:     linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names



On 10/02/2017 10:06, André Draszik wrote:
> They're all referenced as utif in the datasheet, not util.
> 
> Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
> 
> Signed-off-by: André Draszik <git@...red.net>

I was under the impression that I had sent this patch already, maybe it
got lost somewhere along the line

Acked-by: John Crispin <john@...ozen.org>


> ---
>  arch/mips/ralink/mt7620.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 3c7c9bf57bf3..6f892c1f3ad7 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
>  
>  static struct rt2880_pmx_func spis_grp_mt7628[] = {
>  	FUNC("pwm_uart2", 3, 14, 4),
> -	FUNC("util", 2, 14, 4),
> +	FUNC("utif", 2, 14, 4),
>  	FUNC("gpio", 1, 14, 4),
>  	FUNC("spis", 0, 14, 4),
>  };
> @@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
>  
>  static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
>  	FUNC("jtag", 3, 30, 1),
> -	FUNC("util", 2, 30, 1),
> +	FUNC("utif", 2, 30, 1),
>  	FUNC("gpio", 1, 30, 1),
>  	FUNC("p4led_kn", 0, 30, 1),
>  };
>  
>  static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
>  	FUNC("jtag", 3, 31, 1),
> -	FUNC("util", 2, 31, 1),
> +	FUNC("utif", 2, 31, 1),
>  	FUNC("gpio", 1, 31, 1),
>  	FUNC("p3led_kn", 0, 31, 1),
>  };
>  
>  static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
>  	FUNC("jtag", 3, 32, 1),
> -	FUNC("util", 2, 32, 1),
> +	FUNC("utif", 2, 32, 1),
>  	FUNC("gpio", 1, 32, 1),
>  	FUNC("p2led_kn", 0, 32, 1),
>  };
>  
>  static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
>  	FUNC("jtag", 3, 33, 1),
> -	FUNC("util", 2, 33, 1),
> +	FUNC("utif", 2, 33, 1),
>  	FUNC("gpio", 1, 33, 1),
>  	FUNC("p1led_kn", 0, 33, 1),
>  };
> @@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
>  
>  static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
>  	FUNC("jtag", 3, 39, 1),
> -	FUNC("util", 2, 39, 1),
> +	FUNC("utif", 2, 39, 1),
>  	FUNC("gpio", 1, 39, 1),
>  	FUNC("p4led_an", 0, 39, 1),
>  };
>  
>  static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
>  	FUNC("jtag", 3, 40, 1),
> -	FUNC("util", 2, 40, 1),
> +	FUNC("utif", 2, 40, 1),
>  	FUNC("gpio", 1, 40, 1),
>  	FUNC("p3led_an", 0, 40, 1),
>  };
>  
>  static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
>  	FUNC("jtag", 3, 41, 1),
> -	FUNC("util", 2, 41, 1),
> +	FUNC("utif", 2, 41, 1),
>  	FUNC("gpio", 1, 41, 1),
>  	FUNC("p2led_an", 0, 41, 1),
>  };
>  
>  static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
>  	FUNC("jtag", 3, 42, 1),
> -	FUNC("util", 2, 42, 1),
> +	FUNC("utif", 2, 42, 1),
>  	FUNC("gpio", 1, 42, 1),
>  	FUNC("p1led_an", 0, 42, 1),
>  };
>