linux-kernel - Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170210103456.GA16086@kroah.com>
Date:   Fri, 10 Feb 2017 11:34:56 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     peter enderborg <peter.enderborg@...ymobile.com>
Cc:     devel@...verdev.osuosl.org,
        Arve Hjønnevåg <arve@...roid.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Riley Andrews <riandrews@...roid.com>,
        Michal Hocko <mhocko@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/3 staging-next] android: Collect statistics from
 lowmemorykiller

On Fri, Feb 10, 2017 at 10:05:12AM +0100, peter enderborg wrote:
> On 02/10/2017 08:51 AM, Greg Kroah-Hartman wrote:
> > On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
> >> Im not speaking for google, but I think there is a work ongoing to
> >> replace this with user-space code.
> > Really?  I have not heard this at all, any pointers to whom in Google is
> > doing it?
> >
> I think it was mention some of the google conferences. The idea
> is the lmkd that uses memory pressure events to trigger this.
> From git log in lmkd i think Colin Cross is involved.

Great, care to add him to this thread?

> >> Until then we have to polish this version as good as we can. It is
> >> essential for android as it is now.
> > But if no one is willing to do the work to fix the reported issues, why
> > should it remain? 
> It is needed by billions of phones.

Well, something is needed, not necessarily this solution :)

> >  Can you do the work here? 
> No. Change the kernel is only one small part of the solution.

Why can't you work on the whole thing?

> >  You're already working on
> > fixing some of the issues in a differnt way, why not do the "real work"
> > here instead for everyone to benifit from?
> The long term solution is something from AOSP.  As you know
> we tried to contribute this to AOSP.  As OEM we can't turn android
> upside down.  It has to be a step by step.

I posted in AOSP that you should post the patches here as AOSP shouldn't
be taking patches that the community rejects.  There's no reason you
can't also provide the "fix the userspace side" patches into AOSP at the
same time, and provide the "correct" solution here as well.  The kernel
community doesn't care abotu AOSP, nor should anyone expect it to.  You
are going to have to work across both boundries/communities in order to
resolve this properly.

If not, as the kernel developers have pointed out, the in-kernel stuff
will probably be removed as it's causing problems for the upstream
developers, and no one is stepping up to fix it "correctly".

thanks,

greg k-h