linux-kernel - Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29606.1486725644@warthog.procyon.org.uk>
Date:   Fri, 10 Feb 2017 11:20:44 +0000
From:   David Howells <dhowells@...hat.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE

Davidlohr Bueso <dave@...olabs.net> wrote:

> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant security/keyrings/.
> 
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>

Applied.