linux-kernel - Re: [PATCH] x86/selftests: add clobbers for int80 on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2017 14:57:04 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     <linux-kernel@...r.kernel.org>
CC:     <0x7f454c46@...il.com>, Shuah Khan <shuah@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>, <x86@...nel.org>,
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH] x86/selftests: add clobbers for int80 on x86_64

On 02/10/2017 02:52 PM, Dmitry Safonov wrote:
> Kernel erases R8..R11 registers prior returning to userspace
> from int80: https://lkml.org/lkml/2009/10/1/164
>
> GCC can reuse this registers and doesn't expect them to change
> during syscall invocation. I met this kind of bug in CRIU once
> gcc 6.1 and clang stored local variables in those registers
> and the kernel zerofied them during syscall:
> https://github.com/xemul/criu/commit/990d33f1a1cdd17bca6c2eb059ab3be2564f7fa2
>
> By that reason I suggest to add those registers to clobbers
> in selftests.
>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: x86@...nel.org
> Cc: linux-kselftest@...r.kernel.org
> Signed-off-by: Dmitry Safonov <dsafonov@...tuozzo.com>
> ---
>  tools/testing/selftests/x86/fsgsbase.c            |  2 +-
>  tools/testing/selftests/x86/iopl.c                | 10 ++++++++--

Drop this one: iopl doesn't do int80 - it's my failure in grepping.
Will resend.

>  tools/testing/selftests/x86/ldt_gdt.c             | 16 +++++++++++-----
>  tools/testing/selftests/x86/ptrace_syscall.c      |  3 ++-
>  tools/testing/selftests/x86/single_step_syscall.c |  5 ++++-
>  5 files changed, 26 insertions(+), 10 deletions(-)
>

-- 
              Dmitry