linux-kernel - Re: [PATCH] staging: vc04_services: remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170210123928.GA4162@mwanda>
Date:   Fri, 10 Feb 2017 15:40:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Alexander Alemayhu <alexander@...mayhu.com>,
        devel@...verdev.osuosl.org, stefan.wahren@...e.com,
        daniels@...labora.com, swarren@...dotorg.org,
        gregkh@...uxfoundation.org, lee@...nel.org,
        linux-kernel@...r.kernel.org, eric@...olt.net, mzoran@...wfest.net,
        linux-rpi-kernel@...ts.infradead.org, popcornmix@...il.com,
        shorne@...il.com
Subject: Re: [PATCH] staging: vc04_services: remove unused functions

On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future.  Please hold off deleting these until we are further
> > along on that.
> > 
> 
> More generally speaking, I'd like to see all the 
> -Wmissing-declarations/-Wmissing-prototypes warnings addressed
> in the kernel and turn on that warning by default.
> 
> If there are parts of vc04_services that are intentionally
> left in place but currently unused, adding a declaration in the
> header file with a comment should be sufficient to prevent it
> from getting deleted or seeing bogus warnings.

Yeah.  That's true.  There really isn't a good reason to have these
warnings.

regards,
dan carpenter