lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Feb 2017 09:48:37 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Keith Busch <keith.busch@...el.com>, Myron Stowe <myron.stowe@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Jonathan Corbet <corbet@....net>, "David S. Miller" <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org>, Emil Velikov <emil.l.velikov@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>, Stefan Berger <stefanb@...ux.vnet.ibm.com>, Wei Zhang <wzhang@...com>, Kurt Schwemmer <kurt.schwemmer@...rosemi.com>, Stephen Bates <stephen.bates@...rosemi.com>, linux-pci@...r.kernel.org, linux-doc@...r.kernel.org, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Hey Greg, Thanks so much for the review. On 10/02/17 07:51 AM, Greg Kroah-Hartman wrote: > On Thu, Feb 02, 2017 at 11:06:00AM -0700, Logan Gunthorpe wrote: >> + cdev = &stdev->cdev; >> + cdev_init(cdev, &switchtec_fops); >> + cdev->owner = THIS_MODULE; >> + cdev->kobj.parent = &dev->kobj; > > Minor nit, the kobject in a cdev is unlike any other kobject you have > ever seen, don't mess with it, it's not doing anything like you think it > is doing. So no need to set the parent field. Ok, that makes sense. I'll do a v3 shortly. I copied this from drivers/dax/dax.c so when I have a spare moment I'll submit a patch to remove it from there as well. Just to make sure I get this right without extra churn: does this look correct? cdev = &stdev->cdev; cdev_init(cdev, &switchtec_fops); cdev->owner = THIS_MODULE; rc = cdev_add(&stdev->cdev, dev->devt, 1); if (rc) goto err_cdev; dev = &stdev->dev; dev->devt = MKDEV(MAJOR(switchtec_devt), minor); dev->class = switchtec_class; dev->parent = &pdev->dev; dev->groups = switchtec_device_groups; dev->release = stdev_release; dev_set_name(dev, "switchtec%d", minor); rc = device_register(dev); if (rc) { cdev_del(&stdev->cdev); put_device(dev); return ERR_PTR(rc); } Thanks, Logan
Powered by blists - more mailing lists