linux-kernel - Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170210123755.GA1770@x1>
Date:   Fri, 10 Feb 2017 20:37:55 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, mingo@...hat.com,
        hpa@...or.com
Subject: Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld
 script

On 02/10/17 at 12:46pm, Thomas Gleixner wrote:
> On Thu, 2 Feb 2017, Baoquan He wrote:
> 
> > Remove the redundent word "is".
> > 
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > ---
> >  arch/x86/kernel/vmlinux.lds.S | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> > index e79f15f..f8f56b9 100644
> > --- a/arch/x86/kernel/vmlinux.lds.S
> > +++ b/arch/x86/kernel/vmlinux.lds.S
> > @@ -8,8 +8,8 @@
> >   *
> >   *
> >   * Don't define absolute symbols until and unless you know that symbol
> > - * value is should remain constant even if kernel image is relocated
> > - * at run time. Absolute symbols are not relocated. If symbol value should
> > + * value should remain constant even if kernel image is relocated at
> 
> And while at it we could make it a proper sentence:
> 
>   ... you know that the symbol value should .... even if the kernel ....
> 
> > + * run time. Absolute symbols are not relocated. If symbol value should
> 
> If the symbol value ... 
> 
> >   * change if kernel is relocated, make the symbol section relative and
> 
> if the kernel 

Yes, I missed these, let me post v2. Thanks!

> 
> >   * put it inside the section definition.
> >   */
> > -- 
> > 2.5.5
> > 
> >