linux-kernel - Re: [PATCH] Input: pwm-beeper: support customized freq for SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2017 09:48:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Heiko Schocher <hs@...x.de>
Cc:     linux-input@...r.kernel.org, Guan Ben <ben.guan@...bosch.com>,
        Mark Jonas <mark.jonas@...bosch.com>,
        devicetree@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        linux-kernel@...r.kernel.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Manfred Schlaegl <manfred.schlaegl@....at>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] Input: pwm-beeper: support customized freq for SND_BELL

On Tue, Feb 07, 2017 at 06:21:34AM +0100, Heiko Schocher wrote:
> From: Guan Ben <ben.guan@...bosch.com>
> 
> extend the pwm-beeper driver to support customized frequency
> for SND_BELL from device tree.
> 
> Signed-off-by: Guan Ben <ben.guan@...bosch.com>
> Signed-off-by: Mark Jonas <mark.jonas@...bosch.com>
> [hs@...x.de: adapted to 4.10-rc7]
> Signed-off-by: Heiko Schocher <hs@...x.de>
> 
> ---
> 
>  .../devicetree/bindings/input/pwm-beeper.txt       |  3 ++
>  drivers/input/misc/pwm-beeper.c                    | 36 ++++++++++++++++------
>  2 files changed, 30 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> index be332ae..438c6e0 100644
> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> @@ -5,3 +5,6 @@ Registers a PWM device as beeper.
>  Required properties:
>  - compatible: should be "pwm-beeper"
>  - pwms: phandle to the physical PWM device
> +
> +optional properties:
> +- bell-frequency:  bell frequency in Hz

Needs a unit suffix:
bell-frequency-hz or just bell-hz as hz implies frequency.

Or maybe beeper-hz would be more consistant.

Rob