lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Feb 2017 09:18:46 -0800 From: Joe Perches <joe@...ches.com> To: AbdAllah-MEZITI <abdallah.meziti.pro@...il.com>, gregkh@...uxfoundation.org Cc: Florian Fainelli <f.fainelli@...il.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, bcm-kernel-feedback-list@...adcom.com, Stephen Warren <swarren@...dotorg.org>, Lee Jones <lee@...nel.org>, Eric Anholt <eric@...olt.net>, Michael Zoran <mzoran@...wfest.net>, Dan Carpenter <dan.carpenter@...cle.com>, Michael Rupprecht <mail.michaelrupprecht@...il.com>, Colin Ian King <colin.king@...onical.com>, Seraphime Kirkovski <kirkseraph@...il.com>, Arnd Bergmann <arnd@...db.de>, devel@...verdev.osuosl.org, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: bcm2835-audio: fix trailing statements On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote: > Trailing statements should be on next line. [] > diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c [] > @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip) > } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) { > LOG_ERR("Couldn't set the controls for stream %d\n", i); > ret = -1; > - } else LOG_DBG(" Controls set for stream %d\n", i); > + } else > + LOG_DBG(" Controls set for stream %d\n", i); > } > } > LOG_DBG(" .. OUT ret=%d\n", ret); It's curious that checkpatch doesn't catch this and ideally this would also use braces for the last else.
Powered by blists - more mailing lists