lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Feb 2017 10:57:20 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Keith Busch <keith.busch@...el.com>, Myron Stowe <myron.stowe@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Jonathan Corbet <corbet@....net>, "David S. Miller" <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org>, Emil Velikov <emil.l.velikov@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>, Stefan Berger <stefanb@...ux.vnet.ibm.com>, Wei Zhang <wzhang@...com> Cc: Kurt Schwemmer <kurt.schwemmer@...rosemi.com>, Stephen Bates <stephen.bates@...rosemi.com>, linux-pci@...r.kernel.org, linux-doc@...r.kernel.org, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, Logan Gunthorpe <logang@...tatee.com> Subject: [PATCH] switchtec: cleanup cdev init Per a suggestion from Greg Kroah-Hartman [1], don't set the cdev's kobject parent. This allows us to use device_register instead of init and add. [1] https://lkml.org/lkml/2017/2/10/370 --- drivers/pci/switch/switchtec.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c index 82bfd18..014eaec 100644 --- a/drivers/pci/switch/switchtec.c +++ b/drivers/pci/switch/switchtec.c @@ -1222,24 +1222,23 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev) return ERR_PTR(minor); dev = &stdev->dev; - device_initialize(dev); dev->devt = MKDEV(MAJOR(switchtec_devt), minor); - dev->class = switchtec_class; - dev->parent = &pdev->dev; - dev->groups = switchtec_device_groups; - dev->release = stdev_release; - dev_set_name(dev, "switchtec%d", minor); cdev = &stdev->cdev; cdev_init(cdev, &switchtec_fops); cdev->owner = THIS_MODULE; - cdev->kobj.parent = &dev->kobj; rc = cdev_add(&stdev->cdev, dev->devt, 1); if (rc) goto err_cdev; - rc = device_add(dev); + dev->class = switchtec_class; + dev->parent = &pdev->dev; + dev->groups = switchtec_device_groups; + dev->release = stdev_release; + dev_set_name(dev, "switchtec%d", minor); + + rc = device_register(dev); if (rc) { cdev_del(&stdev->cdev); put_device(dev); -- 2.1.4
Powered by blists - more mailing lists