lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Feb 2017 09:46:10 -0800 From: Matthew Wilcox <willy@...radead.org> To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.com>, Andrew Morton <akpm@...ux-foundation.org>, Alexander Viro <viro@...iv.linux.org.uk>, Hugh Dickins <hughd@...gle.com>, Andrea Arcangeli <aarcange@...hat.com>, Dave Hansen <dave.hansen@...el.com>, Vlastimil Babka <vbabka@...e.cz>, Ross Zwisler <ross.zwisler@...ux.intel.com>, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux-block@...r.kernel.org Subject: Re: [PATCHv6 13/37] mm: make write_cache_pages() work on huge pages On Thu, Jan 26, 2017 at 02:57:55PM +0300, Kirill A. Shutemov wrote: > We writeback whole huge page a time. Let's adjust iteration this way. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> I think a lot of the complexity in this patch is from pagevec_lookup_tag giving you subpages rather than head pages... > @@ -2268,7 +2273,8 @@ int write_cache_pages(struct address_space *mapping, > * not be suitable for data integrity > * writeout). > */ > - done_index = page->index + 1; > + done_index = compound_head(page)->index > + + hpage_nr_pages(page); > done = 1; > break; > } you'd still need this line, but it'd only be: done_index = page->index + (1 << compound_order(page)); I think we want: #define nr_pages(page) (1 << compound_order(page)) because we seem to be repeating that idiom quite a lot in these patches. done_index = page->index + nr_pages(page); Still doesn't quite fit on one line, but it's closer, and it's the ridiculous indentation in that function that's the real problem.
Powered by blists - more mailing lists