linux-kernel - RE: [PATCH 4/4] cxgb4: Convert PDBG to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04ce01d28325$0a3dda20$1eb98e60$@opengridcomputing.com>
Date:   Thu, 9 Feb 2017 16:37:05 -0600
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Joe Perches'" <joe@...ches.com>,
        "'Steve Wise'" <swise@...lsio.com>
Cc:     "'Doug Ledford'" <dledford@...hat.com>,
        "'Sean Hefty'" <sean.hefty@...el.com>,
        "'Hal Rosenstock'" <hal.rosenstock@...il.com>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/4] cxgb4: Convert PDBG to pr_debug

> kernel@...r.kernel.org
> Subject: [PATCH 4/4] cxgb4: Convert PDBG to pr_debug
> 
> Use a more typical logging style.
> 
> Miscellanea:
> 
> o Obsolete the c4iw_debug module parameter
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c       | 303
+++++++++++++++++----------------
>  drivers/infiniband/hw/cxgb4/cq.c       |  71 ++++----
>  drivers/infiniband/hw/cxgb4/device.c   |  58 +++----
>  drivers/infiniband/hw/cxgb4/ev.c       |  29 ++--
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h |  44 +++--
>  drivers/infiniband/hw/cxgb4/mem.c      |  28 +--
>  drivers/infiniband/hw/cxgb4/provider.c |  38 ++---
>  drivers/infiniband/hw/cxgb4/qp.c       |  91 +++++-----
>  drivers/infiniband/hw/cxgb4/resource.c |  46 ++---
>  drivers/infiniband/hw/cxgb4/t4.h       |  22 +--
>  10 files changed, 368 insertions(+), 362 deletions(-)


Looks good (and thanks).

Reviewed-by: Steve Wise <swise@...ngridcomputing.com>